Do not call chpwd hooks in setup.zsh #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, cd'ing on zsh calls the shell function chpwd. This is commonly used for things like showing the current directory in the title terminal by printing a string with some escape codes, but this breaks _CATKIN_SETUP_DIR. `-q` disables the chpwd hooks. The zshbuiltins(1) man page writes about -q: "If the -q (quiet) option is specified, the hook function chpwd and the functions in the array chpwd_functions are not called. This is useful for calls to cd that do not change the environment seen by an interactive user."
dirk-thomas
added a commit
that referenced
this pull request
Apr 4, 2014
Do not call chpwd hooks in setup.zsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, cd'ing on zsh calls the shell function
chpwd. This is commonly used for things like showing the current directory in the title terminal by printing a string with some escape codes, but this breaks_CATKIN_SETUP_DIR.-qdisables the chpwd hooks.The zshbuiltins(1) man page writes about -q: "If the -q (quiet) option is specified, the hook function chpwd and the functions in the array chpwd_functions are not called. This is useful for calls to cd that do not change the environment seen by an interactive user."