Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output whitelist/blacklist if set #714

Merged
merged 1 commit into from
Feb 2, 2015
Merged

output whitelist/blacklist if set #714

merged 1 commit into from
Feb 2, 2015

Conversation

dirk-thomas
Copy link
Member

@wjwwood Please review.

@wjwwood
Copy link
Member

wjwwood commented Feb 2, 2015

Does this cover the if(NOT DEFIEND ...) case too, i.e. what happens if CATKIN_WHITELIST_PACKAGES is not defined? Or is it always defined.

@dirk-thomas
Copy link
Member Author

If it is not defined the variable evaluates to an empty string and therefore doesn't output a message.

But with it being defined as an option it is always defined (defaults to an empty string).

@wjwwood
Copy link
Member

wjwwood commented Feb 2, 2015

+1

dirk-thomas added a commit that referenced this pull request Feb 2, 2015
@dirk-thomas
Merge pull request #714 from ros/output_package_whitelist_blacklist
1071c19 
output whitelist/blacklist if set
@dirk-thomas dirk-thomas merged commit 1071c19 into indigo-devel Feb 2, 2015
@dirk-thomas dirk-thomas deleted the output_package_whitelist_blacklist branch February 2, 2015 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @wjwwood