Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catkin_install_python does not update installed files #764

Closed
mgrrx opened this issue Nov 30, 2015 · 2 comments
Closed

catkin_install_python does not update installed files #764

mgrrx opened this issue Nov 30, 2015 · 2 comments
Labels

Comments

@mgrrx
Copy link

mgrrx commented Nov 30, 2015

installing a python script using catkin_install_python(...) installs the script correctly when executed for the first time, but, once you change the script, the installed version remains unchanged. The file will be installed again only if you touch the CMakeLists.txt.

I looked at the function in catkin_install_python.cmake and for me it looks like that it only generates the file once and does not introduce a custom target.

@dirk-thomas
Copy link
Member

Thanks for reporting this. #765 implements a straight forward fix for it. It would also be possible to move the generation logic into the installation step but that would require more changes and also result in a higher install time cost for every file installed by this function. Since commonly these scripts are only calling a main function in the Python package I went for this approach.

It would be great if you could try the PR and confirm that it fixes the problem for you.

@mgrrx
Copy link
Author

mgrrx commented Dec 1, 2015

Thanks for fixing this issue. #765 fixes the problem for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants