avoid adding nonexistent paths to environment variables #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will address the problems manifesting in failing |
|
looks good. you should probably add one more test case which checks the non-existent path gets stripped |
dirk-thomas
force-pushed
the
avoid_nonexistent_paths_in_env
branch
from
980a075 to
cbc409e
Compare
|
Good point, now covered in https://github.com/ros/catkin/pull/777/files#diff-ad1f6ee5eed3025b89ceed022166eab8R70 |
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Feb 19, 2016
avoid adding nonexistent paths to environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without sourcing the setup file for a package contributes its nonexistent paths to all environment variables:
CPATH,LD_LIBRARY_PATH,PATH,PKG_CONFIG_PATHandPYTHONPATH.