parse_package_xml.py: Always write output file as UTF-8 for python3. #828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python3, reading or writing text files by use a default encoding depending on your locale. That means that handling of
package.xml
file containing UTF-8 without a UTF-8 locale doesn't work. See below for an example error.This PR makes sure UTF-8 is used as encoding with python3 regardless of your locale. Note that this is a essentially the same issue as fixed in ros-infrastructure/catkin_pkg#143.