Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to pass specific version to catkin_prepare_release #918

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

dirk-thomas
Copy link
Member

The new option allows to specify arbitrary versions in case bumping major/minor/patch isn't sufficient.

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested up to where it wants to push to the remote repo with and without --version specified. Does anything after catkin_prepare_release force a major.minor.patch format for the version? The script will happily accept any string at the moment.

@dirk-thomas
Copy link
Member Author

Does anything after catkin_prepare_release force a major.minor.patch format for the version? The script will happily accept any string at the moment.

Correct, no enforcement. The caller is in charge of its own fate 😉

@dirk-thomas dirk-thomas force-pushed the catkin_prepare_release_version branch from 99165d2 to 65dc6fb Compare January 26, 2018 19:52
@dirk-thomas
Copy link
Member Author

In expectation of the "worst" I added the same regex check from catkin_pkg: 65dc6fb

@sloretz
Copy link
Contributor

sloretz commented Jan 26, 2018

65dc6fb works for me. It would be more DRY to add and import a check_version function from catkin_pkg.package_version, but as it's just one line I'm fine with it as it.

@dirk-thomas dirk-thomas merged commit 828118a into kinetic-devel Jan 26, 2018
@dirk-thomas dirk-thomas deleted the catkin_prepare_release_version branch January 26, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants