Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catkin_add_gtest_build_flags is missing #931

Closed
trainman419 opened this issue Apr 4, 2018 · 2 comments
Closed

catkin_add_gtest_build_flags is missing #931

trainman419 opened this issue Apr 4, 2018 · 2 comments
Labels

Comments

@trainman419
Copy link
Contributor

http://wiki.ros.org/gtest describes a cmake macro called catkin_add_gtest_build_flags() but it doesn't appear to be present in catkin.

I have a couple of libraries that include shared test functions that use gtest (see ros/ros_comm#1357), and these are currently under-linked on OSX. I'm able to fix them by linking directly against ${GTEST_LIBRARIES} but it seems like it would be better to use the catkin_add_gtest_build_flags() macro for this.

@dirk-thomas
Copy link
Member

Such a function does to my knowledge not exist in catkin and has never existed. Looking at the history of the wiki page it seems this was blindly renamed along time ago: http://wiki.ros.org/action/diff/gtest?action=diff&rev1=53&rev2=54

Currently there are only function to create binaries with gtest, e.g. catkin_add_executable_with_gtest. Similar function for libraries could be introduced if that is a common pattern.

@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 4, 2018

I removed the invalid reference from the wiki page: http://wiki.ros.org/action/diff/gtest?action=diff&rev1=63&rev2=64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants