Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move catkin_prepare_release script as well as dependencies to catkin_pkg #941

Merged
merged 2 commits into from
May 31, 2018

Conversation

dirk-thomas
Copy link
Member

Removed the following scripts:

  • catkin_package_version
  • catkin_prepare_release

Replace the following modules with a "redirect" to the new location in catkin_pkg:

  • package_version
  • terminal_color
  • workspace_vcs

The patch also bumps the minimum version of catkin_pkg to the upcoming version 0.4.3 which will contain ros-infrastructure/catkin_pkg#216.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'm assuming it's failing CI due to needing the unreleased version of catkin_pkg

@dirk-thomas
Copy link
Member Author

I'm assuming it's failing CI due to needing the unreleased version of catkin_pkg

Indeed.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented May 31, 2018

With the changes released in catkin_pkg 0.4.3...

@ros-pull-request-builder retest this please

@dirk-thomas dirk-thomas merged commit 86faa44 into kinetic-devel May 31, 2018
@dirk-thomas dirk-thomas deleted the move_prepare_release branch May 31, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants