remove CMAKE_MODULE_PATH from list of "forbidden" variables #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
approved these changes
Aug 3, 2018
zultron
added a commit
to zultron/catkin_lint
that referenced
this pull request
Aug 3, 2018
In ros/catkin#951, `CMAKE_MODULE_PATH` was removed from the CMake coding standards documentation "Forbidden variables" list. This patch mirrors that change in `catkin lint`. The variable is removed from `critical_vars` and the corresponding tests. Fixes fkie#55.
zultron
added a commit
to zultron/catkin_lint
that referenced
this pull request
Aug 3, 2018
In ros/catkin#951, `CMAKE_MODULE_PATH` was removed from the CMake coding standards documentation "Forbidden variables" list. This patch mirrors that change in `catkin lint`. The variable is removed from `critical_vars` and the corresponding tests. Fixes fkie#55.
roehling
pushed a commit
to fkie/catkin_lint
that referenced
this pull request
Aug 6, 2018
* Remove `CMAKE_MODULE_PATH` from critical variables list In ros/catkin#951, `CMAKE_MODULE_PATH` was removed from the CMake coding standards documentation "Forbidden variables" list. This patch mirrors that change in `catkin lint`. The variable is removed from `critical_vars` and the corresponding tests. Fixes #55. * Add code coverage for `LENGTH`, `APPEND` in list handling The former `CMAKE_MODULE_PATH` critical variable was the only thing testing `LENGTH`; removing that decreased code coverage. This adds the tests back, but applied to the similar `CMAKE_PREFIX_PATH` variable instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950.