Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to install python subpackages #962

Merged

Conversation

jdlangs
Copy link
Contributor

@jdlangs jdlangs commented Oct 5, 2018

As I recently discovered via ROS Answers #273090, there is a non-obvious method to make catkin install python subpackages. Hopefully an explicit note in the docs will help one or two other people faster down the road.

Thanks,
Josh

@dirk-thomas
Copy link
Member

Thank you for the improvement. While this is standard Python setuptools behavior it might help users to mention it explicitly.

Please update the PR to include the same change in the sibling directory format1.

@jdlangs jdlangs force-pushed the python_subpackage_install_note branch from 9aae8ca to 3ed8ca6 Compare October 8, 2018 01:34
@jdlangs jdlangs force-pushed the python_subpackage_install_note branch from 3ed8ca6 to 18431b6 Compare October 8, 2018 01:40
@jdlangs
Copy link
Contributor Author

jdlangs commented Oct 8, 2018

I have to assume there are plenty of other ROS users like me who have never used setuptools so the docs probably shouldn't assume any standard behavior would be known. I did find where this was mentioned in the python packaging docs so I added a link there as well as the format1 version.

@dirk-thomas
Copy link
Member

Thank you for improving the documentation!

@dirk-thomas dirk-thomas merged commit 597583a into ros:kinetic-devel Oct 8, 2018
@jdlangs jdlangs deleted the python_subpackage_install_note branch October 8, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants