Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add script.bat.in template for general use #981

Merged
merged 2 commits into from
Jan 29, 2019
Merged

add script.bat.in template for general use #981

merged 2 commits into from
Jan 29, 2019

Conversation

kejxu
Copy link
Contributor

@kejxu kejxu commented Jan 9, 2019

similar to the use of the bash script template, script.bat.in will be used as a batch script wrapper for rosrun.bat (https://github.com/ms-iot/ros/blob/init_windows/tools/rosbash/CMakeLists.txt#L27)

@dirk-thomas
Copy link
Member

Is this relay script used anywhere else beside rosbash? If not I would rather prefer the logic to be moved to the rosbash package or e.g. simply copy the file rather than using this "emulated symlink style".

@kejxu
Copy link
Contributor Author

kejxu commented Jan 29, 2019

Is this relay script used anywhere else beside rosbash? If not I would rather prefer the logic to be moved to the rosbash package or e.g. simply copy the file rather than using this "emulated symlink style".

Totally agree! We are comfortable with this proposed change because there are existing wrappers in cmake\templates already, this added file will be a Windows counterpart of the existing script.bash.in. If later one day we/ros decide to move these into rosbash, they can be moved all at the same time =)

@dirk-thomas
Copy link
Member

Thank you for the patch.

@dirk-thomas dirk-thomas merged commit 0627d42 into ros:kinetic-devel Jan 29, 2019
@kejxu kejxu deleted the add_script.bat.in_for_general_use branch January 29, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants