update windows.cmake to fix common build issues on Windows #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid using set_target_properties on ALIAS targets This change is to fix the error like below: 2018-11-30T10:40:39.7610068Z CMake Error at C:/opt/ros/melodic/x64/share/catkin/cmake/platform/windows.cmake:47 (set_target_properties): 2018-11-30T10:40:39.7610963Z set_target_properties can not be used on an ALIAS target. 2018-11-30T10:40:39.7611263Z Call Stack (most recent call first): 2018-11-30T10:40:39.7611903Z abseil_cpp/CMake/AbseilHelpers.cmake:67 (add_library) 2018-11-30T10:40:39.7612185Z abseil_cpp/absl/base/CMakeLists.txt:74 (absl_library) * nit
) Walking through the projects we touched for ROS, many of them simply are just missing the dllimport/dllexport declarative, so no imported library is generated and breaks the build for downstream projects. Some are fixed by defining dllexport/dllimport, by defining WINDOWS_EXPORT_ALL_SYMBOLS, or by switching them to STATIC library (STATIC lib sometimes even creates more problems since the author assumes it is a shared lib at run-time). In order to quickly enabling more untouched ROS packages, I am suggesting to enable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS globally to quickly enabling them, but we should still encourage the package owners to explicitly use dllexport in our cookbook.
kejxu
commented
Jan 10, 2019
|
While I am not a big fan of working around the various definitions globally within Thank you for the patch. |
Thanks a lot for your understanding! Hopefully this kind of change could be eventually removed from the global build tool ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while building on Windows, it's not uncommon to encounter various platform-specific issues and compiler-specific issues (if using visual c++ compiler, MSVC).
For the debug flags and compiler options, a lot of these issues are already known to the community, and most of them could be resolved with existing good practices:
-DNOMINMAXhelps avoid collision withstd::min/std::maxif there'swindows.h/windef.h-DNO_STRICT(and-DQ_NOWINSTRICTfor QT) disables STRICT type checking-D_USE_MATH_DEFINESallows using Math Constants since they are not defined in Standard C/C++-DWIN32_LEAN_AND_MEANexcludes various APIs from windows.h to improve build time since basic inclusion would be enough