Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][kinetic] Fix python_distutils_install.bat.in #992

Merged
merged 3 commits into from
Feb 21, 2019
Merged

[Windows][kinetic] Fix python_distutils_install.bat.in #992

merged 3 commits into from
Feb 21, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Feb 20, 2019

  • Fix: PYTHONPATH isn't really passed to python setup.py by cmd /c /v method.
  • Fix: For clean build, @CMAKE_INSTALL_PREFIX@\@PYTHON_INSTALL_DIR@ could not exist, so use mkdir to ensure the existence. (python_distutils_install.sh.in did the same thing.)
  • Fix: move quotation from set ABC="xyz" to set "ABC=xyz" to avoid extra double quotes in the variable, otherwise, which subsequently caused problems for Python to parse the PYTHONPATH.

Here is the issue how does the problem manifest: ms-iot/ROSOnWindows#67

@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 6157b75 into ros:kinetic-devel Feb 21, 2019
@seanyen
Copy link
Contributor Author

seanyen commented Feb 21, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants