Fix travis on macOS. #135
Merged
Fix travis on macOS. #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to install python3 from homebrew, travis was complaining that it couldn't overwrite python2 symlinks with python3 symlinks. Follow the advice given by homebrew and unlink python@2 before trying to install python3. This fixes travis on macOS for me. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mjcarroll
approved these changes
Jan 8, 2020
|
@nuclearsandwich Just FYI, we are going to go ahead and merge this (and cherry-pick over to #133 and #134) so we can land these changes in the next Eloquent patch release. If you disagree with these changes, please feel free to give a review later and we'll fix it up. |
clalancette
added a commit
that referenced
this pull request
Jan 8, 2020
When trying to install python3 from homebrew, travis was complaining that it couldn't overwrite python2 symlinks with python3 symlinks. Follow the advice given by homebrew and unlink python@2 before trying to install python3. This fixes travis on macOS for me. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Jan 8, 2020
When trying to install python3 from homebrew, travis was complaining that it couldn't overwrite python2 symlinks with python3 symlinks. Follow the advice given by homebrew and unlink python@2 before trying to install python3. This fixes travis on macOS for me. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mjcarroll
pushed a commit
that referenced
this pull request
Jan 10, 2020
When trying to install python3 from homebrew, travis was complaining that it couldn't overwrite python2 symlinks with python3 symlinks. Follow the advice given by homebrew and unlink python@2 before trying to install python3. This fixes travis on macOS for me. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mjcarroll
pushed a commit
that referenced
this pull request
Jan 10, 2020
When trying to install python3 from homebrew, travis was complaining that it couldn't overwrite python2 symlinks with python3 symlinks. Follow the advice given by homebrew and unlink python@2 before trying to install python3. This fixes travis on macOS for me. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to install python3 from homebrew, travis was
complaining that it couldn't overwrite python2 symlinks
with python3 symlinks. Follow the advice given by homebrew
and unlink python@2 before trying to install python3. This
fixes travis on macOS for me.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org