Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape messages to avoid CMake warning #49

Merged
merged 1 commit into from
Jul 3, 2014
Merged

Conversation

dirk-thomas
Copy link
Member

Similar to ros/catkin#668. The error message should be escaped to avoid a CMake warning (with 2.8.12 and newer).

@tfoote @wjwwood Please review

@tfoote
Copy link
Member

tfoote commented Jun 29, 2014

+1 I'm surprised there's not a better solution for this along the lines of re.escape but parameterizable.

@wjwwood
Copy link
Member

wjwwood commented Jun 30, 2014

Same thing about str and unicode still applies, but as long as we are confident that the error will not contain unicode +1.

dirk-thomas added a commit that referenced this pull request Jul 3, 2014
escape messages to avoid CMake warning
@dirk-thomas dirk-thomas merged commit 50349e5 into indigo-devel Jul 3, 2014
@dirk-thomas dirk-thomas deleted the escape_messages branch July 3, 2014 18:33
severin-lemaignan referenced this pull request in severin-lemaignan/robotpkg Aug 18, 2014
Changes since 0.4.20:

0.5.3 (2014-07-10)
------------------
* escape messages to avoid CMake warning (`#49
<https://github.com/ros/genmsg/issues/49>`_)

0.5.2 (2014-05-07)
------------------
* refactor to generate pkg-msg-paths.cmake via configure_file() instead of empy
(`#43 <https://github.com/ros/genmsg/issues/43>`_)
* fix python 3 compatibility (`#45 <https://github.com/ros/genmsg/issues/45>`_)
* remove debug message introduced in 0.5.1 (`#42
<https://github.com/ros/genmsg/issues/42>`_)

0.5.1 (2014-03-04)
------------------
* add check for changed message dependencies (`#41
<https://github.com/ros/genmsg/issues/41>`_)

0.5.0 (2014-02-25)
------------------
* remove usage of debug_message() (`#40
<https://github.com/ros/genmsg/issues/40>`_)

0.4.24 (2014-01-07)
-------------------
* python 3 compatibility (`#36 <https://github.com/ros/genmsg/issues/36>`_,
`#37 <https://github.com/ros/genmsg/issues/37>`_)
* add support for ROS_LANG_DISABLE env variable (`ros/ros#39
<https://github.com/ros/ros/issues/39>`_)
* fix installation of __init__.py from devel space (`#38
<https://github.com/ros/genmsg/issues/38>`_)

0.4.23 (2013-09-17)
-------------------
* fix installation of __init__.py file for packages where name differs from
project name (`#34 <https://github.com/ros/genmsg/issues/34>`_)
* rename variable 'config' to not collide with global variable (`#33
<https://github.com/ros/genmsg/issues/33>`_)
* fix service files variable to only contain package relative paths (`#32
<https://github.com/ros/genmsg/issues/32>`_)

0.4.22 (2013-08-21)
-------------------
* make genmsg relocatable (`ros/catkin#490
<https://github.com/ros/catkin/issues/490>`_)
* add warning in case generate_messages() is invoked without any messages and
services (`#31 <https://github.com/ros/genmsg/issues/31>`_)
* check if files have been generated before trying to install them (`#31
<https://github.com/ros/genmsg/issues/31>`_)

0.4.21 (2013-07-03)
-------------------
* check for CATKIN_ENABLE_TESTING to enable configure without tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants