API improvements for use by client code #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Jul 3, 2017
src/genmsg/msg_loader.py
Outdated
| @@ -55,7 +55,12 @@ | |||
| from . srvs import SrvSpec | |||
|
|
|||
| class MsgNotFound(Exception): | |||
| pass | |||
|
|
|||
| def __init__(self, message, base_type, package, search_path): | |||
There was a problem hiding this comment.
Existing code might use the constructor of this class with a single message argument. That needs to continue to work. Therefore please make the new arguments optional.
dirk-thomas
reviewed
Jul 3, 2017
src/genmsg/msg_loader.py
Outdated
| self.base_type = base_type | ||
| self.package = package | ||
| self.search_path = search_path | ||
| super(MsgNotFound, self).__init__(message) |
There was a problem hiding this comment.
Can you please move the super call to the top of the function.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These just add useful API details, so there should be no backward compatibility issues...