xmlrpc_manager: use SteadyTime for timeout #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How will this affect the behavior when e.g. using sim time? I could imagine that existing connections would be ended when simulation is paused. |
Not at all as long as the system time doesn't change.
I'm not exactly sure when a new xmlrpc client is needed, but since it was using WallTime before, it would have had the same effect. So the only difference is that you don't get a timeout if you set the system time forward. |
|
Nvm. Since it was using wall time before I wasn't affected by sim time anyway. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the SteadyTime instead of WallTime when checking if a cached client is dead.