/libros/node_handle: alternative way to fix #838 #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cwecht can you add Fixes #838 to the title. This seems like a better approach. @mikepurvis @dirk-thomas Mentioning you here since you were part of the #838 conversation, and could help merge this is. |
|
Thanks for the patch. |
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 4, 2020
josephduchesne
pushed a commit
to josephduchesne/ros_comm
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1630, also fixes #838.
This approach can actually guarantee, that the TopicManager and ServiceManager instance live as long as the last NodeHandle. With #1630 's approach this can not be guaranteed.