Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when topic can't connect (roscpp and rospy) #222

Open
ahendrix opened this issue May 1, 2013 · 1 comment
Open

Add error message when topic can't connect (roscpp and rospy) #222

ahendrix opened this issue May 1, 2013 · 1 comment

Comments

@ahendrix
Copy link

ahendrix commented May 1, 2013

One of the hard-to-debug problems in ROS is when a publisher is active and registered with the ROS master, but has a bad IP/DNS/ROS_HOSTNAME, so remote clients are not able to connect.

We should consider adding an error message (or making an existing error more visible) to the client libraries whenever the TCP connection to a publisher fails; particularly if it fails during name resolution.

@dirk-thomas
Copy link
Member

For rospy you can check if changing the two lines from logdebug() to logwarn() would be what you want:
https://github.com/ros/ros_comm/blob/groovy-devel/clients/rospy/src/rospy/impl/registration.py#L315
https://github.com/ros/ros_comm/blob/groovy-devel/clients/rospy/src/rospy/impl/registration.py#L318

For the cpp part it will be pretty difficult to achieve. Any new connection attempt is scheduled with a PendingConnection. This one tries forever. Adding a warning at that level will be difficult since in a lot of scenarios the connection will intentionally only be established after some time (when the subscriber actually appears).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants