Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noetic turtle #85

Merged
merged 2 commits into from
May 12, 2020
Merged

Add noetic turtle #85

merged 2 commits into from
May 12, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented May 5, 2020

Add the Noetic turtle icon created by @ColeOSRF

Previous Melodic PR: #41

ColeOSRF and others added 2 commits May 5, 2020 15:47
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@dirk-thomas
Copy link
Member

Please add a screenshot of the rendered turtlesim window with this turtle so see how it looks in the default background. All turtles can be shown by enabling this code block:

// spawn all available turtle types
if(false)

@sloretz
Copy link
Contributor Author

sloretz commented May 5, 2020

Please add a screenshot

Here it is:

Screenshot from 2020-05-05 16-41-50

@dirk-thomas
Copy link
Member

Is the bottom part with the "N" intended to be as is? Just asking since I thought it looks awkward.

@sloretz
Copy link
Contributor Author

sloretz commented May 6, 2020

Is the bottom part with the "N" intended to be as is? Just asking since I thought it looks awkward.

Yup, PM'd to avoid spoiling the Noetic logo before it's announced

@ColeOSRF
Copy link

ColeOSRF commented May 6, 2020 via email

Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just checking since it looked weird to me. If it is intentional it is fine as is.

@dirk-thomas dirk-thomas changed the base branch from melodic-devel to noetic-devel May 12, 2020 21:11
@dirk-thomas dirk-thomas merged commit d656120 into noetic-devel May 12, 2020
@dirk-thomas dirk-thomas deleted the add_noetic_turtle branch May 12, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants