Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore folding logic from Travis or update error messages #25334

Open
dirk-thomas opened this issue Jun 4, 2020 · 2 comments
Open

restore folding logic from Travis or update error messages #25334

dirk-thomas opened this issue Jun 4, 2020 · 2 comments

Comments

@dirk-thomas
Copy link
Member

See e.g.

with Fold() as fold:
print("""Checking if the distribution files of '%s' contain valid urls for known hosting services.
If this fails you can run 'scripts/check_rosdistro_urls.py file://`pwd`/%s %s' to perform the same check locally.
""" % (distro_name, 'index.yaml', distro_name))
if not check_rosdistro_urls(index_url, distro_name):
failed_distros.append(distro_name)
fold_blocks.append(fold.get_block_name())
assert not failed_distros, "There were problems with urls in the distribution files for these distros: %s, see folded blocks above for details: %s" % (failed_distros, fold_blocks)

Regression from #24333.

@dirk-thomas
Copy link
Member Author

@tfoote Friendly ping.

@tfoote
Copy link
Member

tfoote commented Jun 19, 2020

This was discussed in the review on that as an acceptable regression with the improved performance. I'm not going to have time to look at it right now.

If someone has time to look at it . There looks like there's a group and ungroup is an alternative to folding:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants