[Windows][melodic-devel] rework validateCache for portability. #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent change of
for fixing potential TOCTOU issue
, it introduced the usage oflstat
but unfortunately not every platform (e.g.,Windows
) supports thisposix
function.In order to make
rospack
still portable on Windows, this pull request is attempting to rearrange thevalidateCache
implementation to drop thelstat
usage, but still keeps it fromTOCTOU
issue.