Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rospack should honor CATKIN_IGNORE marker files #21

Closed
dirk-thomas opened this issue Jul 5, 2013 · 3 comments
Closed

rospack should honor CATKIN_IGNORE marker files #21

dirk-thomas opened this issue Jul 5, 2013 · 3 comments
Assignees

Comments

@dirk-thomas
Copy link
Member

rospack should ignore all folders containing a CATKIN_IGNORE marker file while crawling for packages.

@dirk-thomas
Copy link
Member Author

Based on issue ros/ros#20.

@meyerj
Copy link

meyerj commented Jul 16, 2013

This patch breaks some setups where CATKIN_IGNORE is used to prevent some packages in a workspace to be built, but nevertheless should be found by rospack (and roscd, roslaunch, rosbuild etc. which I assume are using rospack).

There are already several questions with similar problems on ROS answers:

Is there another marker file like the former ROS_NOBUILD (or CATKIN_NOBUILD, CATKIN_BLACKLIST) which can be used to blacklist a package during catkin_make but keep it findable by rospack (e.g. containing only launch files, non-catkin packages which contain a package.xml, etc.)?

@dirk-thomas
Copy link
Member Author

No, there is no differentiation. Either a package is visible - for build and runtime - or it is ignored. I don't think that it is a good idea to add another marker file which even has different semantic for build and runtime.

The problem described in your referenced questions is all about dry packages where the CATKIN_IGNORE file is generated for an in-source build (which is fixed with the latest version currently in shadow-fixed).

As mentioned in one of the questions you can specify --pkg for catkin_make and catkin_make_isolated. But this will only give you limited control about which packages to build. If you end up wanting to build only a subset of a workspace but keep all package available at runtime you should really split up the workspace.

severin-lemaignan referenced this issue in severin-lemaignan/robotpkg Aug 18, 2014
Drop patch-aa for tinyxml location, this is now handled by
devel/ros-cmake-modules.

Changes since 2.1.19:

2.2.4 (2014-07-10)
------------------
* fix find_package(PythonLibs ...) with CMake 3 (`#42
<https://github.com/ros/rospack/issues/42>`_)

2.2.3 (2014-05-07)
------------------
* find library for exact Python version (even if not in CMake provided list of
version numbers) (`#40 <https://github.com/ros/rospack/issues/40>`_)
* find TinyXML using cmake_modules (`#24
<https://github.com/ros/rospack/issues/24>`_)
* make error messages tool specific (rospack vs. rosstack) (`#38
<https://github.com/ros/rospack/issues/38>`_)

2.2.2 (2014-02-25)
------------------
* python 3 compatibility (`#35 <https://github.com/ros/rospack/issues/35>`_)

2.2.1 (2014-02-24)
------------------
* only perform backquote substitution when needed (`#34
<https://github.com/ros/rospack/issues/34>`_)

2.2.0 (2014-01-30)
------------------
* add hash of ROS_PACKAGE_PATH to rospack/rosstack cache filename, remove
ROS_ROOT from cache (`#28 <https://github.com/ros/rospack/issues/28>`_)

2.1.22 (2014-01-07)
-------------------
* use specific python version catkin has decided on (`#29
<https://github.com/ros/rospack/issues/29>`_)
* python 3 compatibility (`#25 <https://github.com/ros/rospack/issues/25>`_,
`#27 <https://github.com/ros/rospack/issues/27>`_)
* fall back gracefully whe gtest is not available
* update package urls

2.1.21 (2013-07-05)
-------------------
* honor CATKIN_IGNORE marker file when crawling for packages (`#21
<https://github.com/ros/rospack/issues/21>`_)

2.1.20 (2013-07-03)
-------------------
* improve error message to include package names when circular dependency is
detected (`#18 <https://github.com/ros/rospack/issues/18>`_)
* check for CATKIN_ENABLE_TESTING to enable configure without tests
* add '-h' option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants