Add md5 of ROS_PACKAGE_PATH to cache file names. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This won't overwrite the cache if a different workspace is selected. Falls back to a single filename if openssl is not available at compile-time.
|
The dependency on openssl is rather extreme for hashing the RPP. Also since the dependency is not expressed in the package manifest the buildfarm would not have it available and therefore Debian packages would be built without it. Anyway I think a more lightweight hash function could be used instead. What about |
|
|
Removed openssl dependency.
dirk-thomas
added a commit
that referenced
this pull request
Jan 30, 2014
ghost
assigned
|
I used your patch as a template for pull request #30. I removed ROS_ROOT from the cache and updated the semantic of the |
dirk-thomas
added a commit
that referenced
this pull request
Jan 30, 2014
dirk-thomas
added a commit
that referenced
this pull request
Jan 30, 2014
add hash of ROS_PACKAGE_PATH to rospack/rosstack cache, remove ROS_ROOT from cache (#28)
severin-lemaignan
referenced
this pull request
in severin-lemaignan/robotpkg
Aug 18, 2014
Drop patch-aa for tinyxml location, this is now handled by devel/ros-cmake-modules. Changes since 2.1.19: 2.2.4 (2014-07-10) ------------------ * fix find_package(PythonLibs ...) with CMake 3 (`#42 <https://github.com/ros/rospack/issues/42>`_) 2.2.3 (2014-05-07) ------------------ * find library for exact Python version (even if not in CMake provided list of version numbers) (`#40 <https://github.com/ros/rospack/issues/40>`_) * find TinyXML using cmake_modules (`#24 <https://github.com/ros/rospack/issues/24>`_) * make error messages tool specific (rospack vs. rosstack) (`#38 <https://github.com/ros/rospack/issues/38>`_) 2.2.2 (2014-02-25) ------------------ * python 3 compatibility (`#35 <https://github.com/ros/rospack/issues/35>`_) 2.2.1 (2014-02-24) ------------------ * only perform backquote substitution when needed (`#34 <https://github.com/ros/rospack/issues/34>`_) 2.2.0 (2014-01-30) ------------------ * add hash of ROS_PACKAGE_PATH to rospack/rosstack cache filename, remove ROS_ROOT from cache (`#28 <https://github.com/ros/rospack/issues/28>`_) 2.1.22 (2014-01-07) ------------------- * use specific python version catkin has decided on (`#29 <https://github.com/ros/rospack/issues/29>`_) * python 3 compatibility (`#25 <https://github.com/ros/rospack/issues/25>`_, `#27 <https://github.com/ros/rospack/issues/27>`_) * fall back gracefully whe gtest is not available * update package urls 2.1.21 (2013-07-05) ------------------- * honor CATKIN_IGNORE marker file when crawling for packages (`#21 <https://github.com/ros/rospack/issues/21>`_) 2.1.20 (2013-07-03) ------------------- * improve error message to include package names when circular dependency is detected (`#18 <https://github.com/ros/rospack/issues/18>`_) * check for CATKIN_ENABLE_TESTING to enable configure without tests * add '-h' option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't overwrite the cache if a different workspace is selected.
Falls back to a single filename if openssl is not available at
compile-time.