Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release team "franka_release_team" #667

Open
3 tasks
Smith-JackSmith opened this issue Nov 28, 2024 · 1 comment
Open
3 tasks

Add release team "franka_release_team" #667

Smith-JackSmith opened this issue Nov 28, 2024 · 1 comment

Comments

@Smith-JackSmith
Copy link

Smith-JackSmith commented Nov 28, 2024

Tip

Consulting with our Project Owner, it appears that we do not yet have a "release maintainer team"
We do have a group of people who are listed as "maintainers" on some of our repos, but these are not the "release" repos.

In case of any errors in this PR, please contact me as soon as possible.


@Smith-JackSmith
Copy link
Author

It was only accident that I arrived at what I am hoping is the correct input to this template.

* [FIRST_REPOSITORY](SOURCE URL)
    * [ros/rosdistro source entry](LINK TO SOURCE FIELD IN ROS/ROSDISTRO)

The template uses uppercase text (e.g., FIRST_REPOSITORY) to indicate placeholders. This deviates from common practices (e.g., note the chevrons), making it harder to identify what needs to be replaced.

Suggestion:

** [<YOUR_REPOSITORY_NAME>](<YOUR_REPOSITORY_SOURCE_URL>)
    * [ros/<YOUR_ROSDISTRO> source entry](<LINK_TO_LINE_NUMBER_OF_SOURCE_FIELD>)

Example of Proper Formatting

* [ament_cmake](https://github.com/ament/ament_cmake.git)
    * [ros/rolling source entry](https://github.com/ros/rosdistro/blob/0d66d7f62975229ed0b1031137f8324ee568cc3e/rolling/distribution.yaml#L149)

Instructions for Filling This Template

  1. Repository Name and Source URL:

    • Replace <YOUR_REPOSITORY_NAME> with the name of your repository.
    • Replace <YOUR_REPOSITORY_SOURCE_URL> with the link to your source repository.
  2. Adding a Permalink to the Source Field:

    • Navigate to the appropriate distribution.yml file for your ROS distribution (e.g., humble/distribution.yml).
    • Find the "source" entry corresponding to your repository.
    • Click the line number to the left of the entry.
    • A menu will appear. Select "Copy Permalink" to generate a stable link to that line.
  3. Replace <LINK_TO_LINE_NUMBER_OF_SOURCE_FIELD>:

    • Paste the copied permalink into the placeholder.

Final Template Example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant