-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make take_boxed() create messages directly on the heap #281
Comments
Hi, I'm considering contribution to this issue. However, I need some hints how to start. AFAIK this and this Box::new functions have to be replaced with another one (which? from_raw?). Also I've found the following comment in
How should the signature look like? I assume that it should return a pointer, but how to achieve that? |
Hi! I've wanted to make a PR for this one as well but I've been having some issues with setting up the environment. As far as I understand from the discussion in rust-lang/rust#53827 the safest way would be to use @Nizerlak will probably have a PR before me anyway :) |
I've actually already looked into this a while back, so I pushed my work-in-progress branch in case one of you wants to take over: main...take_boxed Let me know if that helps. The main problem I was facing was that the |
Currently, the implementation of
take_boxed()
will place the message on the stack during intermediate steps, even though the intent of this function is to avoid that, since large messages might overflow the stack.This requires avoiding any
Box::new()
calls, see rust-lang/rust#53827The text was updated successfully, but these errors were encountered: