Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler substitution for package files #374

Open
jdlangs opened this issue Aug 15, 2023 · 2 comments
Open

Simpler substitution for package files #374

jdlangs opened this issue Aug 15, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@jdlangs
Copy link

jdlangs commented Aug 15, 2023

Feature request

Feature description

Looking at a launch file tutorial, I was struck by the verbose use of both the PathJoinSubstitution and FindPackageShare substitutions. It would be very easy to simplify this for the end-user with a single FindPackageFile substitution, for example. Is there any reason this wasn't done originally and would such a change be welcomed?

@clalancette
Copy link
Contributor

I don't think there is a specific reason this wasn't originally done. We'd be happy to review a pull request that adds this functionality.

@clalancette clalancette added the help wanted Extra attention is needed label Aug 24, 2023
@GlowingScrewdriver
Copy link

I've got two questions:

  1. Would this substitution be something that takes in just a package name and a launch file name? As in:
PythonLaunchDescriptionSource([
   FindPackageFile ('launch_tutorial', 'example_substitutions.launch.py')
])
  1. How appropriate would it be to have a similar feature for Yaml launch files? Just enough capability to allow importing a given launch file from a given package? It would definitely allow for a lot more launch files to be written in Yaml instead of Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants