Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

How to include poco in package.xml #26

Closed
ahcorde opened this issue Feb 17, 2020 · 1 comment
Closed

How to include poco in package.xml #26

ahcorde opened this issue Feb 17, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ahcorde
Copy link

ahcorde commented Feb 17, 2020

I have been checking how we include poco in the package.xml across the official ros2 packages.

In same of them:

  • poco_vendor and rmw_implementation
 <depend>libpoco-dev</depend>
 <depend>poco_vendor</depend>
  • class_loader, rosidl_typesupport_c and rosidl_typesupport_cpp
  <build_depend>libpoco-dev</build_depend>
  <exec_depend>libpoco-dev</exec_depend>

I think libpoco-dev shouldn't be a <exec_depend> or <depend> because it's just something that we use for building.

the right approach should be something like:

  <build_depend>libpoco-dev</build_depend>
  <exec_depend>poco_vendor</exec_depend>

@wjwwood and @dirk-thomas which are your thoughts?

@ahcorde ahcorde added the enhancement New feature or request label Feb 17, 2020
@ahcorde ahcorde self-assigned this Feb 17, 2020
@ahcorde
Copy link
Author

ahcorde commented Apr 6, 2020

Closing this issue because poco will be removed from ros2 dependencies ros2/rcutils#216

@ahcorde ahcorde closed this as completed Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant