-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move security related filesystem and env utilities outside rcl #545
Comments
It's probably better to consolidate discussion. To reiterate my comment (#544 (comment)):
|
I found the past discussion I was thinking about in #332. In particular, I agree with this #332 (comment):
|
I do agree with the #332 comment, isolate rcl from security configuration giving the users the right to implement theirs.
and
are appealing to us. Is there any roadmap for such changes? |
I'm not aware of any explicit roadmap, but we can start by using this ticket for tracking progress. |
I've closed the connected |
This issue has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-10-15/16849/1 |
This issue has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-without-a-file-system/16942/1 |
This issue has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-without-a-file-system/16942/4 |
Feature request
Feature description
Move file system dependant functionality to
rcutils
will increase the ROS 2 possible targets.rcl/rcl/src/rcl/node.c
Line 320 in 3a5c3a3
In this concrete case, I propose to
move rcl_get_secure_root
API torcutils
.This way, rcl will be "easy" to cross-compile for systems with no filesystem.
Keeping the core mostly platform-independent.
In
rcutils
there are already other utilities for the filesystem.Implementation considerations
We propose to have and
rcutils_get_secure_root
API and be called in the same place asrcl_get_secure_root
is called right now. These two pull request implements the proposed solution over dashing:The text was updated successfully, but these errors were encountered: