Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages in rcl_lifecycle #655

Closed
ahcorde opened this issue May 18, 2020 · 3 comments
Closed

Improve error messages in rcl_lifecycle #655

ahcorde opened this issue May 18, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ahcorde
Copy link
Contributor

ahcorde commented May 18, 2020

rcl_lifecycle is using only two kind of errors: RCL_RET_ERROR and RCL_RET_OK. There is room for improvement here. We should add a more accurate error message.
@ahcorde ahcorde added enhancement New feature or request good first issue Good for newcomers labels May 18, 2020
@brawner
Copy link
Contributor

brawner commented May 18, 2020

Thanks for opening the issue @ahcorde! For reference, this follows up #649, where we decided to hold off on changing return codes until after the foxy release

@dirk-thomas dirk-thomas added the help wanted Extra attention is needed label Jul 9, 2020
@fujitatomoya fujitatomoya mentioned this issue Aug 12, 2020
Merged
@llapx
Copy link
Contributor

llapx commented Aug 12, 2020

I just modify the headers files, mainly for document, if it's OK, I will push the code, thanks!

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 5, 2020

Closed via #742

@ahcorde ahcorde closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brawner @dirk-thomas @ahcorde @llapx