You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not opposed to it, but I'm also not sure if it is a really important thing to do either.
A few somewhat unimportant things to consider:
using std::bind in rclcpp gives us implicit coverage on that use case, which is nice but not required as we have demos that cover that case too
in the example you gave, std::bind is slightly nicer because we don't need to include the type of event, and don't think auto would work in this case due to how the template deduction works on that
But I don't think those points push me one way or the other that much.
Feature request
Feature description
Replace all
std::bind
withlambda
. Is it worth doing it for now?isocpp/CppCoreGuidelines#1796
Implementation considerations
e.g.
Replace
rclcpp/rclcpp/src/rclcpp/time_source.cpp
Lines 130 to 133 in e9e398d
The text was updated successfully, but these errors were encountered: