Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old set parameters callback API #499

Closed
jacobperron opened this issue Jan 29, 2020 · 0 comments · Fixed by #504
Closed

Deprecate old set parameters callback API #499

jacobperron opened this issue Jan 29, 2020 · 0 comments · Fixed by #504
Assignees
@jacobperron
Labels
enhancement New feature or request

Comments

@jacobperron
Copy link
Member

Feature request

Feature description

Similar to what was done in rclcpp (ros2/rclcpp#791), once support for multiple parameter callbacks (#393), we should deprecate the older API, which is no longer needed.

Implementation considerations

Specifically, the following function should be deprecated:

rclpy/rclpy/rclpy/node.py

Lines 1022 to 1025 in 30eeae9

def set_parameters_callback(
self,
callback: Callable[[List[Parameter]], SetParametersResult]
) -> None:

@jacobperron jacobperron changed the title Deprecate old set parameters API Deprecate old set parameters callback API Jan 29, 2020
@jacobperron jacobperron added the enhancement New feature or request label Jan 29, 2020
@jacobperron jacobperron self-assigned this Feb 6, 2020
@jacobperron jacobperron mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobperron jacobperron

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate set_parameters_callback API ros2/rclpy
1 participant
@jacobperron