You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently using rclpy in intended ways causes typing errors due to partially unknown types of multiple methods. Even the simplest functionality (creating a publisher or a subscription) does not typecheck (tested using pylance). I've written much better typing stubs for myself, including making rclpy Subscription and Publisher generic over the mesage type, and Future generic over the return type. Would it be a welcome change to this repo to add those improved typings? Those are not evaluated at runtime, so they can't break existing code, but it would greatly improve the experience for anyone using static type checking
The text was updated successfully, but these errors were encountered:
We've added lot of types in the last year or so, though it is not 100% done yet. Given that, I'm going to close this out as "mostly done", and we can follow-up with individual PRs as needed.
Currently using rclpy in intended ways causes typing errors due to partially unknown types of multiple methods. Even the simplest functionality (creating a publisher or a subscription) does not typecheck (tested using pylance). I've written much better typing stubs for myself, including making rclpy Subscription and Publisher generic over the mesage type, and Future generic over the return type. Would it be a welcome change to this repo to add those improved typings? Those are not evaluated at runtime, so they can't break existing code, but it would greatly improve the experience for anyone using static type checking
The text was updated successfully, but these errors were encountered: