Remove test for large allocation failure. #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has potential performance implications, and also causes build warnings on 32-bit platforms since the size is too big to fit into a size_t. It's also a pretty artificial test, so just remove it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI just on armhf to prove that the warning is gone:
|
mjcarroll
approved these changes
Mar 6, 2020
|
@clalancette Thanks for tagging me, I'll use a different approach to test the case covered by that portion of code. |
Blast545
approved these changes
Mar 6, 2020
Sounds good, thanks for understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has potential performance implications, and also causes
build warnings on 32-bit platforms since the size is too big
to fit into a size_t. It's also a pretty artificial test,
so just remove it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This should fix one of the build warnings in https://ci.ros2.org/view/nightly/job/nightly_linux-armhf_debug/409/warnings23Result/new/ . @Blast545 FYI.