add freebsd support #223
Merged
add freebsd support #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Dodson <md403@cam.ac.uk>
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-compiling for FreeBSD often results in satisfying
__GNUC__conditionals if no__FreeBSD__conditionals are provided. In most cases, it should execute the same code as the__APPLE__conditionals.This PR ensures the correct code is executed for FreeBSD. This is necessary in one case (process.c:50). In a second case (process.c:74), it is added for completeness, just in case the
__APPLE__and__GNUC__cases diverge in the future.macros.h:34 also checks if
__APPLE__is defined, but separate code to support FreeBSD does not appear to be necessary in this case, as the conditional appears to be iOS-specific.