Added debug version for library names #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
reviewed
Apr 8, 2020
| } | ||
| #elif _WIN32 | ||
| if (buffer_size >= (strlen(library_name) + 7)) { |
There was a problem hiding this comment.
Just for the record: the 7 was incorrect before and is being fixed in this patch.
There was a problem hiding this comment.
maybe it's just not trivial for me to see, but would it make sense to set this hardcoded numbers to constants to give some semantics to it?
dirk-thomas
approved these changes
Apr 8, 2020
|
jacobperron
added a commit
that referenced
this pull request
Apr 9, 2020
This reverts commit 2daeb12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen this error on the buildfarm in PluginLib. Requesting for a missing reference
class_loader::systemLibrarySuffixthis function was removed from class_loader. I integrate this on rcutilsSigned-off-by: ahcorde ahcorde@gmail.com