Add a RCUTILS_DEPRECATED macro to enable platform specific deprecation #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides an equivalent to ROS_DEPRECATED Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
jacobperron
approved these changes
Apr 10, 2020
include/rcutils/macros.h
Outdated
| @@ -92,6 +92,13 @@ extern "C" | |||
| __attribute__ ((format(printf, format_string_index, first_to_check_index))) | |||
| #endif // !defined _WIN32 || defined __CYGWIN__ | |||
|
|
|||
| /// Macro to declare deprecation in the platform appropriate mannor. | |||
There was a problem hiding this comment.
Suggested change
| /// Macro to declare deprecation in the platform appropriate mannor. | |
| /// Macro to declare deprecation in the platform appropriate manner. |
ivanpauno
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
LGTM!
I think that both Windows and non-windows have a way to add a deprecation message:
- https://docs.microsoft.com/en-us/cpp/cpp/deprecated-cpp?view=vs-2019
- https://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Function-Attributes.html
It would be great to add a RCUTILS_DEPRECATED_WITH_MSG macro too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an equivalent to ROS_DEPRECATED