Reset error state after testing expected errors #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change eliminates unnecessary output from the string_array tests when running operations that are expected to set error information. It does not change the intended behavior of the tests, but suppresses the extra output when the tests are functioning as expected. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added
enhancement
hidmic
approved these changes
May 15, 2020
ahcorde
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates unnecessary output from the
string_arraytests when running operations that are expected to set error information. It does not change the intended behavior of the tests, but suppresses the extra output when the tests are functioning as expected.The idea is to make it easier to use the output to debug an actual failure, which is easier to do when you don't need to wade through the output from the expected failures overwriting each other.