Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed doxygen warnings #266

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Removed doxygen warnings #266

merged 3 commits into from
Jul 22, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 10, 2020

Improved API documentation, removed doxygen warnings

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from Blast545 July 10, 2020 12:01
@ahcorde ahcorde self-assigned this Jul 10, 2020
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions

include/rcutils/logging.h Outdated Show resolved Hide resolved
include/rcutils/strerror.h Outdated Show resolved Hide resolved
@Blast545
Copy link
Contributor

I just saw this has merging issues with the PR job, please check that before merging @ahcorde

@ahcorde ahcorde requested a review from Blast545 July 21, 2020 09:30
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde ahcorde merged commit d242a0f into master Jul 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/doxygen/warnings branch July 22, 2020 05:19
ahcorde added a commit that referenced this pull request Jul 22, 2020
* Removed doxygen warnings

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jul 22, 2020
* Removed doxygen warnings

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
@jacobperron jacobperron mentioned this pull request Jul 27, 2020
ahcorde added a commit that referenced this pull request Jul 28, 2020
* Removed doxygen warnings

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
hidmic pushed a commit that referenced this pull request Jul 28, 2020
* Removed doxygen warnings

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants