Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds QNX support for rcutils_get_executable_name #282

Merged
merged 1 commit into from
Aug 24, 2020
Merged

adds QNX support for rcutils_get_executable_name #282

merged 1 commit into from
Aug 24, 2020

Conversation

asobhy-qnx
Copy link
Contributor

Fixes #281

adds the global variable "__progname", which holds the basename of the program being executed, in function rcutils_get_executable_name(rcutils_allocator_t allocator)

reference:
http://www.qnx.com/developers/docs/6.5.0/index.jsp?topic=%2Fcom.qnx.doc.neutrino_lib_ref%2Fp%2F__progname.html

@dirk-thomas
Copy link
Member

@asobhy-qnx Please see the failing linter check and update the patch to pass it.

Signed-off-by: asobhy <asobhy@blackberry.com>
@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 444fa85 into ros2:master Aug 24, 2020
@asobhy-qnx asobhy-qnx deleted the qnx-support branch August 27, 2020 17:50
@asobhy-qnx
Copy link
Contributor Author

@dirk-thomas can this be back ported to dashing and foxy?

jacobperron pushed a commit that referenced this pull request Nov 10, 2020
Signed-off-by: asobhy <asobhy@blackberry.com>
jacobperron pushed a commit that referenced this pull request Nov 10, 2020
Signed-off-by: asobhy <asobhy@blackberry.com>
jacobperron added a commit that referenced this pull request Nov 11, 2020
Signed-off-by: asobhy <asobhy@blackberry.com>

Co-authored-by: Ahmed Sobhy <68698147+asobhy-qnx@users.noreply.github.com>
jacobperron added a commit that referenced this pull request Nov 18, 2020
Signed-off-by: asobhy <asobhy@blackberry.com>

Co-authored-by: Ahmed Sobhy <68698147+asobhy-qnx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QNX support - program_invocation_name undeclared
2 participants