Performance tests demo

[Blast545]

Testing performance test usage for rcutils/error_handling.h and rcutils/logging.h.

IMO it would be a good idea to combine coverage measurements to see which parts of the code are run with the performance tests, investigation pending.

[fujitatomoya]

It would be nice to integrate performance benchmark test. but for doing that, we should be able to have some criteria or threshold to decide if performance is not good enough? I think that most likely this performance check is gonna be useful to make sure if the staging PR does not affect the performance aspect. Could you share your thoughts about this kind of plan?

[Blast545]

@fujitatomoya There is a pending discussion on #278 for this package, we will be discussing what's reasonable to test for each package in terms of performance and include checks on CI to be able of checking when a PR affects considerably performance to be considered before merging.

[ahcorde]

Does it make sense to add a new folder for the benchmark tests?

[Blast545]

• Linux
• Linux-aarch64
• macOS
• Windows

[ahcorde]

I have two suggestions:

• call the target benchmark_logging instead of benchmark_test_logging. I think is redundant somehow.
• remove the word test from the filename. (test_benchmark_logging.cpp -> benchmark_logging.cpp)

[Blast545]

• Linux
• Linux-aarch64
• macOS
• Windows

[clalancette]

@Blast545 What's the status of this one? Should we merge it?

[ahcorde]

@clalancette I believe that rhe idea it's to create end-to-end performance tests instead of microbenchmarks.

Maybe @chapulina can add more context here.

[chapulina]

Yes, the new plan is to create end-to-end tests. But it looks like this PR is already approved and close to getting in, so it would be a shame to throw it away. What's missing to merge it?

[clalancette]

Yes, the new plan is to create end-to-end tests. But it looks like this PR is already approved and close to getting in, so it would be a shame to throw it away. What's missing to merge it?

Yeah, agreed. If this is almost ready to go, then I would say we get this in, but don't build any new micro-benchmarks.

[Blast545]

CI:

• Linux

[clalancette]

Here is full CI on this to make sure everything is happy. If it is, I'll go ahead and merge it:

• Linux
• Linux-aarch64
• macOS
• Windows

Stale