use one copy for continuous area instead of loop copy #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
approved these changes
Nov 12, 2020
|
|
||
| ret = rcutils_array_list_get(&list, 0, &ret_data); | ||
| EXPECT_EQ(RCUTILS_RET_OK, ret) << rcutils_get_error_string().str; | ||
| EXPECT_EQ((uint32_t)2, ret_data) << rcutils_get_error_string().str; |
There was a problem hiding this comment.
maybe we would want to call the following after this,
- rcutils_array_list_remove(&list, 0)
- rcutils_array_list_get_size(&list, &size)
to make sure corner case which is to remove last entry from the array_list.
There was a problem hiding this comment.
reasonable 👍
clalancette
requested changes
Nov 13, 2020
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
iuhilnehc-ynos
force-pushed
the
topic-one-copy
branch
from
b3085ff to
524b621
Compare
clalancette
approved these changes
Nov 13, 2020
|
CI:
|
|
Hi, @clalancette |
No, I don't think so. Those tests have been flaky in the nightlies for a while. This one just fell off of my radar, thanks for the ping. I'm going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Lihui lihui.chen@sony.com