Fix a leak during error handling in dir size calculation #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added
bug
clalancette
approved these changes
Jan 12, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net>
|
The clang build on macOS pointed out that jumping to the error handling label leaves some rather ambiguous behavior regarding variables that are initialized later in the function. I updated this change to specifically free the allocated memory and return rather than jump to the label. Alternatively, we could move the variable declarations and initializations earlier in the function, but due to the platform-specific |
clalancette
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have to free the memory allocated on line 357.
FYI @Barry-Xu-2018