Remove references of __xstat #330
Conversation
|
It looks like the tests failed in CI; that's likely because mimick needs this function to mock everything properly. @hidmic could you take a look and maybe provide some context here? |
|
Maybe I should add a version constraint. |
Remove some refs of __xstat to fix building errors in Arch Linux. Also tested passed on Ubuntu 18.04 and Ubuntu 20.04. __xstat was removed in glibc 2.33, so do not use it anymore. Signed-off-by: Nxxx <nx.tardis@gmail.com>
|
The idea here looks OK to me. I'm going to run a full CI on it on all platforms to see what happens.
|
|
All of the unstable tests on Windows are also unstable on the nightlies, so there don't seem to be any regressions here. I'd still like to get @hidmic's opinion before merging, so I'll hold off on merging this one for now. |
|
I'm going to go ahead and merge this one. @hidmic feel free to leave comments afterwards if you have any concerns. |
|
Argh, this one got lost in my inbox. Patch looks good to me. The thing with (older) glibc is that source API and binary API do not always match (like in this case). That's why these tests are forced to target |
As mentioned in issue 329.
I've removed some refs of __xstat to fix building errors in Arch Linux. Also tested passed on Ubuntu 18.04 and Ubuntu 20.04.
__xstat was removed in glibc 2.33, so do not use it anymore.