Fix if(TARGET ...) condition for test #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
christophebedard
requested review from
ahcorde,
clalancette and
wjwwood
as code owners
fujitatomoya
approved these changes
Feb 1, 2024
|
|
CI looks good, as expected. @fujitatomoya I'll let you merge. |
|
@christophebedard done! thanks, good eye 👍 |
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai> (cherry picked from commit b6ba6a1)
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai> (cherry picked from commit b6ba6a1)
This was referenced Feb 2, 2024
audrow
pushed a commit
that referenced
this pull request
Feb 15, 2024
audrow
pushed a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't look intentional and doesn't really change much in practice. Probably a copy/paste error from #320.