Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed warnings - strict-prototypes #461

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Removed warnings - strict-prototypes #461

merged 1 commit into from
Apr 23, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 17, 2024

There are new warnings on CI related with this compiler option strict-prototypes

https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1860/gcc/new/

@ahcorde
Removed warnings - strict-prototypes
9991740 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 17, 2024
fujitatomoya
fujitatomoya approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

clalancette
clalancette approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

Let's put this on the queue to merge after the freeze is over.

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

Errors on arch64 are related with a bug in gcc, in particular in mimick

mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'

@ahcorde ahcorde merged commit 3da73bc into rolling Apr 23, 2024
3 checks passed
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

https://github.com/Mergifyio backport jazzy

@delete-merged-branch delete-merged-branch bot deleted the ahcorde/remove/warnings branch April 23, 2024 11:36
@mergify Mergify
Copy link

mergify bot commented Apr 23, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 23, 2024
@ahcorde @mergify
Removed warnings - strict-prototypes (#461)
be899a6 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 3da73bc)
@mergify mergify bot mentioned this pull request Apr 23, 2024
Merged
ahcorde added a commit that referenced this pull request Apr 23, 2024
@mergify @ahcorde
Removed warnings - strict-prototypes (#461) (#465)
fceec34 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 3da73bc)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette clalancette approved these changes

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @clalancette @fujitatomoya