Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity check for rcutils_steady_time_now #88

Closed
serge-nikulin opened this issue Feb 5, 2018 · 3 comments
Closed

sanity check for rcutils_steady_time_now #88

serge-nikulin opened this issue Feb 5, 2018 · 3 comments
Assignees
Labels
in progress Actively being worked on (Kanban column)

Comments

@serge-nikulin
Copy link

serge-nikulin commented Feb 5, 2018

rcutils_steady_time_now currently trusts the OS specific implementations to provide truly monotonic time values. Issue #86 and Internet show the monotonicity claim should be verified.

@mikaelarguedas mikaelarguedas added the in review Waiting for review (Kanban column) label Feb 6, 2018
@mikaelarguedas
Copy link
Member

Thanks @serge-nikulin, we were indeed using "true" monotonic clocks in the past and changes the behavior to match what we get from chrono at the c++ level. linking to the relevant issue here for book-keeping: #43

@serge-nikulin
Copy link
Author

@mikaelarguedas, because of non-monotonic Windows steady timer (due to overflow in previous ROS2 implementation, fixed by #87) I had a silent failure in a publisher's executor.

This fix forces the system to non-silent error state in similar failure mode on all platforms.

@wjwwood wjwwood added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Feb 8, 2018
@wjwwood wjwwood self-assigned this May 22, 2018
@clalancette
Copy link
Contributor

I'm going to close this as sort of a duplicate of #43. If you disagree, feel free to reopen (but I think we need an explicit actionable thing to do here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Actively being worked on (Kanban column)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants