Coverity report data leak

[danielwangksu]

It seems request.buffer_ = new eprosima::fastcdr::FastBuffer(); did not get deleted

rmw_fastrtps/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_service_info.hpp

Lines 70 to 102 in 62b7534

	onNewDataMessage(eprosima::fastrtps::Subscriber * sub)
	{
	assert(sub);
	CustomServiceRequest request;
	request.buffer_ = new eprosima::fastcdr::FastBuffer();
	eprosima::fastrtps::SampleInfo_t sinfo;
	rmw_fastrtps_shared_cpp::SerializedData data;
	data.is_cdr_buffer = true;
	data.data = request.buffer_;
	if (sub->takeNextData(&data, &sinfo)) {
	if (eprosima::fastrtps::rtps::ALIVE == sinfo.sampleKind) {
	request.sample_identity_ = sinfo.sample_identity;
	std::lock_guard<std::mutex> lock(internalMutex_);
	if (conditionMutex_ != nullptr) {
	std::unique_lock<std::mutex> clock(*conditionMutex_);
	list.push_back(request);
	// the change to list_has_data_ needs to be mutually exclusive with
	// rmw_wait() which checks hasData() and decides if wait() needs to
	// be called
	list_has_data_.store(true);
	clock.unlock();
	conditionVariable_->notify_one();
	} else {
	list.push_back(request);
	list_has_data_.store(true);
	}
	}
	}
	}

[mabelzhang]

@danielwangksu Thanks for finding these! Do you want to open a PR to address this and #305?

[clalancette]

This one has long been refactored and changed to fix the leak, so I'll close this out.