Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Mistake on Tutorial of Using parameters in a class (Python) #3134

Closed
929937690 opened this issue Oct 26, 2022 · 1 comment · Fixed by #3135
Closed

Minor Mistake on Tutorial of Using parameters in a class (Python) #3134

929937690 opened this issue Oct 26, 2022 · 1 comment · Fixed by #3135

Comments

@929937690
Copy link

929937690 commented Oct 26, 2022

On this tutorial link
In the section 3 Build and Run:
It says:
The terminal should return the following message every 2 seconds:
[INFO] [parameter_node]: Hello world!

But since the callback timer set to 1 second, should this part be:
The terminal should return the following message every seconds:
[INFO] [parameter_node]: Hello world!

(Not only with foxy version, the other version also have the same content)

Please correct me if I am wrong! Thank you!

@clalancette
Copy link
Contributor

Yes, you are totally right. Thanks for reporting. See #3135 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants