ros2 pkg create for ament_python packages should include xmllint #944
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Feature request
ament/ament_cmake#553
Feature description
New
ament_python
packages should include an xmllint test to match the default linters given to ament_cmake packagesImplementation considerations
Copy this file:
https://github.com/ros2/ros2cli/blob/rolling/ros2pkg/test/test_xmllint.py
Here:
https://github.com/ros2/ros2cli/tree/rolling/ros2pkg/ros2pkg/resource/ament_python
Make sure
test/test_xmllint.py
is created in new packages here:ros2cli/ros2pkg/ros2pkg/api/create.py
Lines 173 to 188 in a3198b8
Make sure the
package.xml
gets a<test_depend>
onament_xmllint
here:ros2cli/ros2pkg/ros2pkg/verb/create.py
Lines 140 to 141 in a3198b8
Bonus: create
ament_python
equivalent tests with assertion thattest/test_xmllint.py
exists here:ros2cli/ros2pkg/test/test_cli.py
Line 122 in a3198b8
The text was updated successfully, but these errors were encountered: